Revert "Hikey960: Change to use recommended power state id format"
authorLeo Yan <leo.yan@linaro.org>
Wed, 3 Jan 2018 06:52:19 +0000 (14:52 +0800)
committerLeo Yan <leo.yan@linaro.org>
Tue, 16 Jan 2018 14:17:58 +0000 (22:17 +0800)
commite1b27425ecb407ba2a4985be5d83d95dfb10b7ac
tree38faacd8683ab7d92e96f5d0c7849e7767c8348f
parentac4626dc4845a82aa0a86c92134bbd996eaf0357
Revert "Hikey960: Change to use recommended power state id format"

This reverts commit fdae60b6ba27c216fd86d13b7432a1ff4f57dd84.

The commit fdae60b6ba27c216fd86d13b7432a1ff4f57dd84 changed the
parameter encoding for the hikey960.  However that implies a DT change
in the kernel side.  After submitting the DT change for upstreaming,
the backward compatibility issue and the interface change raise some
concerns from the Linux community about the issues related to kernel <->
ATF alignment.  There is no way to detect a mis-alignment of those
without a deep knowledge of the ATF and the kernel.  Furthermore, the
failing calls to PSCI in the idle path (because of bad parameters), will
lead to busy looping, implying: thermal issues and extra energy
consumption.

In regard of the Linux community concerns, the potential issues when the
ATF and the kernel are not aligned, it is preferable to revert the
commit.

Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: Kevin Wang <jean.wangtao@linaro.org>
Co-authored-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Leo Yan <leo.yan@linaro.org>
plat/hisilicon/hikey960/hikey960_pm.c
plat/hisilicon/hikey960/include/platform_def.h