[media] tuner-core/simple: get_rf_strength can be tuner mode specific
authorHans Verkuil <hans.verkuil@cisco.com>
Sat, 6 Apr 2013 07:41:29 +0000 (04:41 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 14 Apr 2013 22:44:50 +0000 (19:44 -0300)
commitdfc2e12df02d49a1567bc90989ceef870cf5b147
tree772748f182a85c71d118f94c8e38a2a8ef05f8f7
parenta2192cf47f593681cd65798880853c5224066c81
[media] tuner-core/simple: get_rf_strength can be tuner mode specific

The get_rf_strength op in tuner-simple is valid only for the radio mode.
But due to the way get_signal in analog_demod_ops was designed it would
overwrite the signal value with a bogus value when in TV mode.
Pass a pointer to the signal value instead, and when not in radio mode
leave it alone in the tuner-simple.
This broke in commit 030755bde42bbed133182b0ece7c7a9c759478e8
(tuner-core: call has_signal for both TV and radio) in kernel 3.6. Before
that this was working correctly. That commit did the right thing, but what
wasn't realized at the time was that tuner-simple should have been updated
as well to restrict setting the signal strength to the radio mode only.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb-core/dvb_frontend.h
drivers/media/tuners/tda8290.c
drivers/media/tuners/tuner-simple.c
drivers/media/v4l2-core/tuner-core.c