arm64: KVM: Avoid setting the upper 32 bits of VTCR_EL2 to 1
authorWill Deacon <will.deacon@arm.com>
Thu, 13 Dec 2018 16:06:14 +0000 (16:06 +0000)
committerMarc Zyngier <marc.zyngier@arm.com>
Wed, 19 Dec 2018 17:47:52 +0000 (17:47 +0000)
commitdf655b75c43fba0f2621680ab261083297fd6d16
treececc5ca40b3c50a183ec7994b869d882e99a65ec
parent6794ad5443a2118243e13879f94228524a1a2b92
arm64: KVM: Avoid setting the upper 32 bits of VTCR_EL2 to 1

Although bit 31 of VTCR_EL2 is RES1, we inadvertently end up setting all
of the upper 32 bits to 1 as well because we define VTCR_EL2_RES1 as
signed, which is sign-extended when assigning to kvm->arch.vtcr.

Lucky for us, the architecture currently treats these upper bits as RES0
so, whilst we've been naughty, we haven't set fire to anything yet.

Cc: <stable@vger.kernel.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Christoffer Dall <christoffer.dall@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
arch/arm64/include/asm/kvm_arm.h