iwlwifi: mvm: fix potential SKB leak on TXQ TX
authorJohannes Berg <johannes.berg@intel.com>
Wed, 11 Dec 2019 09:15:52 +0000 (10:15 +0100)
committerLuca Coelho <luciano.coelho@intel.com>
Mon, 23 Dec 2019 23:34:52 +0000 (01:34 +0200)
commitdf2378ab0f2a9dd4cf4501268af1902cc4ebacd8
treeab85d3d4a6c8aa7a689e434be1d19ec93858d7ba
parentb9f726c94224e863d4d3458dfec2e7e1284a39ce
iwlwifi: mvm: fix potential SKB leak on TXQ TX

When we transmit after TXQ dequeue, we aren't paying attention to
the return value of the transmit functions, leading to a potential
SKB leak.

Refactor the code a bit (and rename ..._tx to ..._tx_sta) to check
for this happening.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Fixes: cfbc6c4c5b91 ("iwlwifi: mvm: support mac80211 TXQs model")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
drivers/net/wireless/intel/iwlwifi/mvm/mvm.h
drivers/net/wireless/intel/iwlwifi/mvm/tx.c