SUNRPC: Address Kerberos performance/behavior regression
authorChuck Lever <chuck.lever@oracle.com>
Wed, 9 Jan 2019 15:04:57 +0000 (10:04 -0500)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Tue, 15 Jan 2019 20:36:41 +0000 (15:36 -0500)
commitdeaa5c96c2f7e8b934088a1e70a0fe8797bd1149
tree8b78410665a7e6c1f52bbc3c9e7092953f5fc761
parent97b78ae96ba76f4ca2d8f5afee6a2e567ccb8f45
SUNRPC: Address Kerberos performance/behavior regression

When using Kerberos with v4.20, I've observed frequent connection
loss on heavy workloads. I traced it down to the client underrunning
the GSS sequence number window -- NFS servers are required to drop
the RPC with the low sequence number, and also drop the connection
to signal that an RPC was dropped.

Bisected to commit 918f3c1fe83c ("SUNRPC: Improve latency for
interactive tasks").

I've got a one-line workaround for this issue, which is easy to
backport to v4.20 while a more permanent solution is being derived.
Essentially, tk_owner-based sorting is disabled for RPCs that carry
a GSS sequence number.

Fixes: 918f3c1fe83c ("SUNRPC: Improve latency for interactive ... ")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
net/sunrpc/xprt.c