ASoC: Intel: bytcr_rt565: fix missing assignment to ret_val
authorColin Ian King <colin.king@canonical.com>
Wed, 2 May 2018 14:29:45 +0000 (15:29 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 3 May 2018 01:23:54 +0000 (10:23 +0900)
commitde5afce2a22ef7f92e9e8583a3bdbc10e448cddf
treeeb9f7465c2029a3bc6390df7fbc077be52a9b112
parent40c57963789d451c26269e3bc9f9e803060fd9af
ASoC: Intel: bytcr_rt565: fix missing assignment to ret_val

Currently, the check that ret_val is not -ENOENT is always true and
the quirk bit BYT_RY5651_MCLK_EN is never being cleared because ret_val
is always zero at this point from a previous assignment earlier on.
I believe that ret_val should actually be assigned to the return from
devm_clk_get() as this can return -ENOENT (from a deeper call to
clk_get_sys) and that was the original intention to check this.

Detected by CoverityScan, CID#1460228 ("Logically dead code")

Fixes: 02c0a3b3047f ("ASoC: Intel: bytcr_rt5651: add MCLK, quirks and cleanups")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/bytcr_rt5651.c