ext4: do not update s_last_mounted of a frozen fs
authorAmir Goldstein <amir73il@gmail.com>
Mon, 14 May 2018 02:54:44 +0000 (22:54 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 14 May 2018 02:54:44 +0000 (22:54 -0400)
commitdb6516a5e7ddb6dc72d167b920f2f272596ea22d
treece820da46d4ef3e3f6f0a688f326d408ba8c506f
parent833a950882d33a7dfc319d5e152fdf35028936eb
ext4: do not update s_last_mounted of a frozen fs

If fs is frozen after mount and before the first file open, the
update of s_last_mounted bypasses freeze protection and prints out
a WARNING splat:

$ mount /vdf
$ fsfreeze -f /vdf
$ cat /vdf/foo

[   31.578555] WARNING: CPU: 1 PID: 1415 at
fs/ext4/ext4_jbd2.c:53 ext4_journal_check_start+0x48/0x82

[   31.614016] Call Trace:
[   31.614997]  __ext4_journal_start_sb+0xe4/0x1a4
[   31.616771]  ? ext4_file_open+0xb6/0x189
[   31.618094]  ext4_file_open+0xb6/0x189

If fs is frozen, skip s_last_mounted update.

[backport hint: to apply to stable tree, need to apply also patches
 vfs: add the sb_start_intwrite_trylock() helper
 ext4: factor out helper ext4_sample_last_mounted()]

Cc: stable@vger.kernel.org
Fixes: bc0b0d6d69ee ("ext4: update the s_last_mounted field in the superblock")
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
fs/ext4/file.c