bpf: Support pre-2.25-binutils objcopy for vmlinux BTF
authorStanislav Fomichev <sdf@google.com>
Wed, 27 Nov 2019 16:14:10 +0000 (08:14 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 27 Nov 2019 19:11:42 +0000 (11:11 -0800)
commitda5fb18225b49b97bb37c51bcbbb2990a507c364
tree2d8c17dcb803aee714dd523ceacea53824021fdb
parentd0f010434124598988ba1c97fbb0e4e820ff5d8c
bpf: Support pre-2.25-binutils objcopy for vmlinux BTF

If vmlinux BTF generation fails, but CONFIG_DEBUG_INFO_BTF is set,
.BTF section of vmlinux is empty and kernel will prohibit
BPF loading and return "in-kernel BTF is malformed".

--dump-section argument to binutils' objcopy was added in version 2.25.
When using pre-2.25 binutils, BTF generation silently fails. Convert
to --only-section which is present on pre-2.25 binutils.

Documentation/process/changes.rst states that binutils 2.21+
is supported, not sure those standards apply to BPF subsystem.

v2:
* exit and print an error if gen_btf fails (John Fastabend)

v3:
* resend with Andrii's Acked-by/Tested-by tags

Fixes: 341dfcf8d78ea ("btf: expose BTF info through sysfs")
Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Tested-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20191127161410.57327-1-sdf@google.com
scripts/link-vmlinux.sh