net/sched: cls_flower: Mandate mask when matching on flags
authorOr Gerlitz <ogerlitz@mellanox.com>
Thu, 22 Dec 2016 12:28:15 +0000 (14:28 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Dec 2016 16:59:56 +0000 (11:59 -0500)
commitd9724772e69cb8076231202292665ca74eec13e1
tree98863f3ad1541e041d7a043f2f46005e45cd3fbd
parentdc594ecd4185831031d3fef2853ee76908428107
net/sched: cls_flower: Mandate mask when matching on flags

When matching on flags, we should require the user to provide the
mask and avoid using an all-ones mask. Not doing so causes matching
on flags provided w.o mask to hit on the value being unset for all
flags, which may not what the user wanted to happen.

Fixes: faa3ffce7829 ('net/sched: cls_flower: Add support for matching on flags')
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reported-by: Paul Blakey <paulb@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/cls_flower.c