perf annotate TUI browser: Do not use member from variable within its own initialization
authorArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 28 May 2019 19:02:56 +0000 (16:02 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Sat, 6 Jul 2019 19:59:11 +0000 (16:59 -0300)
commitd5b2179d6a675ee8cdbd3250d42f1e32d5a45fb1
treef94e3a452bf151880c5f904936ef2d33aef45ca5
parentbff5a556c149804de29347a88a884d25e4e4e3a2
perf annotate TUI browser: Do not use member from variable within its own initialization

Some compilers will complain when using a member of a struct to
initialize another member, in the same struct initialization.

For instance:

  debian:8      Debian clang version 3.5.0-10 (tags/RELEASE_350/final) (based on LLVM 3.5.0)
  oraclelinux:7 clang version 3.4.2 (tags/RELEASE_34/dot2-final)

Produce:

  ui/browsers/annotate.c:104:12: error: variable 'ops' is uninitialized when used within its own initialization [-Werror,-Wuninitialized]
                                              (!ops.current_entry ||
                                                ^~~
  1 error generated.

So use an extra variable, initialized just before that struct, to have
the value used in the expressions used to init two of the struct
members.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Fixes: c298304bd747 ("perf annotate: Use a ops table for annotation_line__write()")
Link: https://lkml.kernel.org/n/tip-f9nexro58q62l3o9hez8hr0i@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/annotate.c