tcp: remove redundant check on tskb
authorColin Ian King <colin.king@canonical.com>
Thu, 4 Apr 2019 14:46:03 +0000 (15:46 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 7 Apr 2019 01:18:14 +0000 (18:18 -0700)
commitd1edc085559744fbda7a55e97eeae8bd6135a11b
tree64bd82f21b8a038ee6a89f2ac89174d307123f87
parentcdf369cd5808fccd1d10cbf68f39429709410f31
tcp: remove redundant check on tskb

The non-null check on tskb is always false because it is in an else
path of a check on tskb and hence tskb is null in this code block.
This is check is therefore redundant and can be removed as well
as the label coalesc.

if (tsbk) {
        ...
} else {
        ...
        if (unlikely(!skb)) {
                if (tskb)       /* can never be true, redundant code */
                        goto coalesc;
                return;
        }
}

Addresses-Coverity: ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_output.c