scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error
authorCathy Avery <cavery@redhat.com>
Tue, 19 Dec 2017 18:32:48 +0000 (13:32 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 21 Dec 2017 02:23:11 +0000 (21:23 -0500)
commitd1b8b2391c24751e44f618fcf86fb55d9a9247fd
tree2507cec8ef2579be0e26692663b91cbec2053563
parent81b6c999897919d5a16fedc018fe375dbab091c5
scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error

When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
which has zero good_bytes it must be assigned an error. Otherwise the
I/O will be continuously requeued and will cause a deadlock in the case
where disks are being hot added and removed. sd_probe_async will wait
forever for its I/O to complete while holding scsi_sd_probe_domain.

Also returning the default error of DID_TARGET_FAILURE causes multipath
to not retry the I/O resulting in applications receiving I/O errors
before a failover can occur.

Signed-off-by: Cathy Avery <cavery@redhat.com>
Signed-off-by: Long Li <longli@microsoft.com>
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/storvsc_drv.c