drm/i915: Compute and commit color features in fastsets
authorJosé Roberto de Souza <jose.souza@intel.com>
Fri, 8 Mar 2019 00:00:44 +0000 (16:00 -0800)
committerJosé Roberto de Souza <jose.souza@intel.com>
Fri, 8 Mar 2019 18:31:42 +0000 (10:31 -0800)
commitd168da8cfc7c49895fabc5570bfb2656013eb12c
tree23ae23b86bb68a4c11b27979a0c543aac24a965f
parent54da1d43c609bd250984290f9d08965ecaae53a0
drm/i915: Compute and commit color features in fastsets

In any commit, intel_modeset_pipe_config() will initialilly clear
and then recalculate most of the pipe states but it leave intel
specific color features states in reset state.

If after intel_pipe_config_compare() is detected that a fastset is
possible it will mark update_pipe as true and unsed mode_changed,
causing the color features state to be kept in reset state and then
latter being committed to hardware disabling the color features.

This issue can be reproduced by any code patch that duplicates the
actual(with color features already enabled) state and only mark
mode_changed as true.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190308000050.6226-3-jose.souza@intel.com
drivers/gpu/drm/i915/intel_display.c