s390/uaccess: get_user() should zero on failure (again)
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Mon, 27 Mar 2017 07:48:04 +0000 (09:48 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Thu, 30 Mar 2017 06:18:59 +0000 (08:18 +0200)
commitd09c5373e8e4eaaa09233552cbf75dc4c4f21203
tree6bb8d0f317d621a46e39ef5a9883a22559a5c7af
parentca681ec860d6533b8debda4f6ab2e70e6d519d89
s390/uaccess: get_user() should zero on failure (again)

Commit fd2d2b191fe7 ("s390: get_user() should zero on failure")
intended to fix s390's get_user() implementation which did not zero
the target operand if the read from user space faulted. Unfortunately
the patch has no effect: the corresponding inline assembly specifies
that the operand is only written to ("=") and the previous value is
discarded.

Therefore the compiler is free to and actually does omit the zero
initialization.

To fix this simply change the contraint modifier to "+", so the
compiler cannot omit the initialization anymore.

Fixes: c9ca78415ac1 ("s390/uaccess: provide inline variants of get_user/put_user")
Fixes: fd2d2b191fe7 ("s390: get_user() should zero on failure")
Cc: stable@vger.kernel.org
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
arch/s390/include/asm/uaccess.h