drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers
authorMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Wed, 20 Dec 2017 09:35:43 +0000 (10:35 +0100)
committerMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Wed, 20 Dec 2017 13:49:06 +0000 (14:49 +0100)
commitce0769e0ea4b3e192466243a1a9fd39acf214f1e
treeb1ae3ef6f6f9f4822d0d742b1a4f53cf32f54fea
parent2c08cd7c20968ddf71feeac2265b4741d2b3fdde
drm/plane: Make framebuffer refcounting the responsibility of setplane_internal callers

lock_all_ctx in setplane_internal may return -EINTR, and
__setplane_internal could return -EDEADLK. Making more
special cases for fb would make the code even harder to
read, so the easiest solution is not taking over the fb
refcount, and making callers responsible for dropping
the ref.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102707
Fixes: 13736ba3b38b ("drm/legacy: Convert setplane ioctl locking to interruptible.")
Testcase: kms_atomic_interruptible
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171220093545.613-2-maarten.lankhorst@linux.intel.com
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_plane.c