tcp: avoid infinite loop in tcp_splice_read()
authorEric Dumazet <edumazet@google.com>
Fri, 3 Feb 2017 22:59:38 +0000 (14:59 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 7 Feb 2017 03:38:55 +0000 (22:38 -0500)
commitccf7abb93af09ad0868ae9033d1ca8108bdaec82
treea3d41e0f7a625bc45ea5396cfcf4a400284112cf
parentb3f2d07f4649adcf6905953a10d217b5683e4077
tcp: avoid infinite loop in tcp_splice_read()

Splicing from TCP socket is vulnerable when a packet with URG flag is
received and stored into receive queue.

__tcp_splice_read() returns 0, and sk_wait_data() immediately
returns since there is the problematic skb in queue.

This is a nice way to burn cpu (aka infinite loop) and trigger
soft lockups.

Again, this gem was found by syzkaller tool.

Fixes: 9c55e01c0cc8 ("[TCP]: Splice receive support.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: Willy Tarreau <w@1wt.eu>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp.c