bnxt_en: Fix NULL pointer dereference at bnxt_free_irq().
authorMichael Chan <michael.chan@broadcom.com>
Wed, 11 Apr 2018 15:50:18 +0000 (11:50 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Apr 2018 18:42:00 +0000 (14:42 -0400)
commitcb98526bf9b985866d648dbb9c983ba9eb59daba
tree40224fb747b9e4a9733c6a4874815eff998da672
parent11c3ec7bb940b6fa3f87f05f01b7f45eef08dfbb
bnxt_en: Fix NULL pointer dereference at bnxt_free_irq().

When open fails during ethtool -L ring change, for example, the driver
may crash at bnxt_free_irq() because bp->bnapi is NULL.

If we fail to allocate all the new rings, bnxt_open_nic() will free
all the memory including bp->bnapi.  Subsequent call to bnxt_close_nic()
will try to dereference bp->bnapi in bnxt_free_irq().

Fix it by checking for !bp->bnapi in bnxt_free_irq().

Fixes: e5811b8c09df ("bnxt_en: Add IRQ remapping logic.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c