libata: remove superfluous NULL pointer checks
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Sun, 26 Jul 2009 14:05:13 +0000 (16:05 +0200)
committerJeff Garzik <jgarzik@redhat.com>
Wed, 29 Jul 2009 01:06:13 +0000 (21:06 -0400)
commitc9abde12d6debe5b97f36fb43cf188c1b9cd477f
tree0bd6a455f9b21ade1cc5dc4a2eaab29a670ec175
parent705d201414382b0966d7c903d738dfdb9380e4af
libata: remove superfluous NULL pointer checks

host->ports[] always contain pointers to valid port structures since
a "dummy port" structure is used in case if there is no physical port.

This patch takes care of two entries from Dan's list:

drivers/ata/sata_sil.c +535 sil_interrupt(13) warning: variable derefenced before check 'ap'
drivers/ata/sata_mv.c +2517 mv_unexpected_intr(6) warning: variable derefenced before check 'ap'

and of another needless NULL pointer check in pata_octeon_cf.c.

Reported-by: Dan Carpenter <error27@gmail.com>
Cc: corbet@lwn.net
Cc: eteo@redhat.com
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/pata_octeon_cf.c
drivers/ata/sata_mv.c
drivers/ata/sata_sil.c