net: socket: fix potential spectre v1 gadget in socketcall
authorJeremy Cline <jcline@redhat.com>
Fri, 27 Jul 2018 22:43:01 +0000 (22:43 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 29 Jul 2018 05:43:30 +0000 (22:43 -0700)
commitc8e8cd579bb4265651df8223730105341e61a2d1
treea2d787f02fe5e97e3f49b002ca26aea04d8815e8
parent958b4cd8fa4c2eff0c257b07f2bb753b7c7a6f52
net: socket: fix potential spectre v1 gadget in socketcall

'call' is a user-controlled value, so sanitize the array index after the
bounds check to avoid speculating past the bounds of the 'nargs' array.

Found with the help of Smatch:

net/socket.c:2508 __do_sys_socketcall() warn: potential spectre issue
'nargs' [r] (local cap)

Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Jeremy Cline <jcline@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/socket.c