projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 07467e5) | patch
staging: line6: do not return 0 from probe if no initialization done
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Tue, 10 Jun 2014 20:22:50 +0000 (00:22 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Jun 2014 00:12:01 +0000 (17:12 -0700)
commitc7f268df3f4e80513271aea8e91f3fd0701aae1b
tree32386baf2f96e5f3fb9f1fa5554b12433fde6406tree | snapshot
parent07467e509b90c75a7c5962c0857857eae79e5c33commit | diff
staging: line6: do not return 0 from probe if no initialization done

There is a strange "return 0" in line6_probe() before any initialization of
the module is done. It can lead to NULL pointer dereference in other functions.
The patch proposes to return -ENODEV in this case.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/line6/driver.c diff | blob | history
John Crispins staging tree