net: add pfmemalloc check in sk_add_backlog()
authorEric Dumazet <edumazet@google.com>
Wed, 30 Sep 2015 01:52:25 +0000 (18:52 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 17 Oct 2015 12:01:11 +0000 (05:01 -0700)
commitc7c49b8fde26b74277188bdc6c9dca38db6fa35b
tree27ac5d0c1469aeacade0db5540362e8e9772b6b4
parent5f715c097965c0ad037f64393d0b95c50287775b
net: add pfmemalloc check in sk_add_backlog()

Greg reported crashes hitting the following check in __sk_backlog_rcv()

BUG_ON(!sock_flag(sk, SOCK_MEMALLOC));

The pfmemalloc bit is currently checked in sk_filter().

This works correctly for TCP, because sk_filter() is ran in
tcp_v[46]_rcv() before hitting the prequeue or backlog checks.

For UDP or other protocols, this does not work, because the sk_filter()
is ran from sock_queue_rcv_skb(), which might be called _after_ backlog
queuing if socket is owned by user by the time packet is processed by
softirq handler.

Fixes: b4b9e35585089 ("netvm: set PF_MEMALLOC as appropriate during SKB processing")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Greg Thelen <gthelen@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/sock.h