tg3: cleanup an error path in tg3_phy_reset_5703_4_5()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 5 Feb 2014 13:29:21 +0000 (16:29 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 7 Feb 2014 04:05:36 +0000 (20:05 -0800)
commitc6e27f2f3cf2631aae6f1f6fae1a7ab083fdb024
treead8c756f552c01b0b853fbd5041310cd1971c9cd
parent63b5f152eb4a5bb79b9caf7ec37b4201d12f6e66
tg3: cleanup an error path in tg3_phy_reset_5703_4_5()

In the original code, if tg3_readphy() fails then it does an unnecessary
check to verify "err" is still zero and then returns -EBUSY.

My static checker complains about the unnecessary "if (!err)" check and
anyway it is better to propagate the -EBUSY error code from
tg3_readphy() instead of hard coding it here.  And really the original
code is confusing to look at.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/tg3.c