rxrpc: Fix the lack of notification when sendmsg() fails on a DATA packet
authorDavid Howells <dhowells@redhat.com>
Tue, 30 Jul 2019 13:42:50 +0000 (14:42 +0100)
committerDavid Howells <dhowells@redhat.com>
Tue, 30 Jul 2019 14:27:59 +0000 (15:27 +0100)
commitc69565ee6681e151e2bb80502930a16e04b553d1
tree2cbe7b19b700ebc1ed1656f3d456f8930360a3e4
parent60034d3d146b11922ab1db613bce062dddc0327a
rxrpc: Fix the lack of notification when sendmsg() fails on a DATA packet

Fix the fact that a notification isn't sent to the recvmsg side to indicate
a call failed when sendmsg() fails to transmit a DATA packet with the error
ENETUNREACH, EHOSTUNREACH or ECONNREFUSED.

Without this notification, the afs client just sits there waiting for the
call to complete in some manner (which it's not now going to do), which
also pins the rxrpc call in place.

This can be seen if the client has a scope-level IPv6 address, but not a
global-level IPv6 address, and we try and transmit an operation to a
server's IPv6 address.

Looking in /proc/net/rxrpc/calls shows completed calls just sat there with
an abort code of RX_USER_ABORT and an error code of -ENETUNREACH.

Fixes: c54e43d752c7 ("rxrpc: Fix missing start of call timeout")
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
net/rxrpc/sendmsg.c