tipc: fix possible crash in __tipc_nl_net_set()
authorEric Dumazet <edumazet@google.com>
Mon, 16 Apr 2018 15:29:43 +0000 (08:29 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Apr 2018 22:08:18 +0000 (18:08 -0400)
commitc6404122cb18f1fbd2a6dc85ab687f6fa2e454cf
tree446adab675af1e507ab048a2efe35edd427fdd34
parentec518f21cb1a1b1f8a516499ea05c60299e04963
tipc: fix possible crash in __tipc_nl_net_set()

syzbot reported a crash in __tipc_nl_net_set() caused by NULL dereference.

We need to check that both TIPC_NLA_NET_NODEID and TIPC_NLA_NET_NODEID_W1
are present.

We also need to make sure userland provided u64 attributes.

Fixes: d50ccc2d3909 ("tipc: add 128-bit node identifier")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Cc: Ying Xue <ying.xue@windriver.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/net.c
net/tipc/netlink.c