vfs: fix infinite loop caused by clone_mnt race
authorMiklos Szeredi <mszeredi@suse.cz>
Tue, 5 Oct 2010 10:31:09 +0000 (12:31 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 26 Oct 2010 01:24:16 +0000 (21:24 -0400)
commitbe1a16a0ae29a7c90081a657b64aa51cb1a65a27
tree18bef9178b1142d839b906ce3bf38c92eb650ee8
parent89b0fc38cca4e6c92a90b58960881ffc5dddd89c
vfs: fix infinite loop caused by clone_mnt race

If clone_mnt() happens while mnt_make_readonly() is running, the
cloned mount might have MNT_WRITE_HOLD flag set, which results in
mnt_want_write() spinning forever on this mount.

Needs CAP_SYS_ADMIN to trigger deliberately and unlikely to happen
accidentally.  But if it does happen it can hang the machine.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namespace.c