projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8d9f73c) | patch
nfp: abm: fix a memory leak bug
authorQiushi Wu <wu000273@umn.edu>
Sat, 2 May 2020 22:42:59 +0000 (17:42 -0500)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 May 2020 19:04:12 +0000 (12:04 -0700)
commitbd4af432cc71b5fbfe4833510359a6ad3ada250d
tree6eba1b8b3c7f1ac43163fed68f8154f2832ec410tree | snapshot
parent8d9f73c0ad2f20e9fed5380de0a3097825859d03commit | diff
nfp: abm: fix a memory leak bug

In function nfp_abm_vnic_set_mac, pointer nsp is allocated by nfp_nsp_open.
But when nfp_nsp_has_hwinfo_lookup fail, the pointer is not released,
which can lead to a memory leak bug. Fix this issue by adding
nfp_nsp_close(nsp) in the error path.

Fixes: f6e71efdf9fb1 ("nfp: abm: look up MAC addresses via management FW")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/abm/main.c diff | blob | history
John Crispins staging tree