qede: Fix barrier usage after tx doorbell write.
authorManish Chopra <manish.chopra@cavium.com>
Tue, 27 Mar 2018 13:34:41 +0000 (06:34 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 27 Mar 2018 17:11:46 +0000 (13:11 -0400)
commitb9fc828debc8ac2bb21b5819a44d2aea456f1c95
treed354c2be9e3bedb62886a87377efe8d53fbde07d
parentdc6455a71c7fc5117977e197f67f71b49f27baba
qede: Fix barrier usage after tx doorbell write.

Since commit c5ad119fb6c09b0297446be05bd66602fa564758
("net: sched: pfifo_fast use skb_array") driver is exposed
to an issue where it is hitting NULL skbs while handling TX
completions. Driver uses mmiowb() to flush the writes to the
doorbell bar which is a write-combined bar, however on x86
mmiowb() does not flush the write combined buffer.

This patch fixes this problem by replacing mmiowb() with wmb()
after the write combined doorbell write so that writes are
flushed and synchronized from more than one processor.

V1->V2:
-------
This patch was marked as "superseded" in patchwork.
(Not really sure for what reason).Resending it as v2.

Signed-off-by: Ariel Elior <ariel.elior@cavium.com>
Signed-off-by: Manish Chopra <manish.chopra@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qede/qede_fp.c