timekeeping/vsyscall: Prevent math overflow in BOOTTIME update
authorThomas Gleixner <tglx@linutronix.de>
Thu, 22 Aug 2019 11:00:15 +0000 (13:00 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 23 Aug 2019 00:12:11 +0000 (02:12 +0200)
commitb99328a60a482108f5195b4d611f90992ca016ba
tree694e2d7be207a6d3220e5346e8b94f470083656e
parent59c36bc8d377c8764eb617a92211e0fc2f1318da
timekeeping/vsyscall: Prevent math overflow in BOOTTIME update

The VDSO update for CLOCK_BOOTTIME has a overflow issue as it shifts the
nanoseconds based boot time offset left by the clocksource shift. That
overflows once the boot time offset becomes large enough. As a consequence
CLOCK_BOOTTIME in the VDSO becomes a random number causing applications to
misbehave.

Fix it by storing a timespec64 representation of the offset when boot time
is adjusted and add that to the MONOTONIC base time value in the vdso data
page. Using the timespec64 representation avoids a 64bit division in the
update code.

Fixes: 44f57d788e7d ("timekeeping: Provide a generic update_vsyscall() implementation")
Reported-by: Chris Clayton <chris2553@googlemail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Chris Clayton <chris2553@googlemail.com>
Tested-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1908221257580.1983@nanos.tec.linutronix.de
include/linux/timekeeper_internal.h
kernel/time/timekeeping.c
kernel/time/vsyscall.c