drm/fb: avoid setting 0 depth.
authorDave Airlie <airlied@redhat.com>
Fri, 15 Mar 2019 01:46:21 +0000 (11:46 +1000)
committerDave Airlie <airlied@redhat.com>
Sun, 24 Mar 2019 23:25:20 +0000 (09:25 +1000)
commitb6a36e5ddf8496ec83a14589f32f58bbaf022046
treeb51310074502049f404a286bb8071001ca8783c7
parent8c2ffd9174779014c3fe1f96d9dc3641d9175f00
drm/fb: avoid setting 0 depth.

If the downscaling fails and we end up with a best_depth of 0,
then ignore it.

This actually works around a cascade of failure, but it the
simplest fix for now.

The scaling patch broke the udl driver, as the udl driver doesn't
expose planes at all, so gets the two default 32-bit formats, but
the udl driver then ask for 16bpp fbdev, and the scaling code falls
over.

This fixes the udl driver since the scaled depth support was added.

Fixes: f4bd542bcaee ("drm/fb-helper: Scale back depth to supported maximum")
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190315014621.21816-2-airlied@gmail.com
drivers/gpu/drm/drm_fb_helper.c