taprio: don't reject same mqprio settings
authorIvan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Tue, 19 Nov 2019 00:23:12 +0000 (02:23 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Nov 2019 23:23:15 +0000 (15:23 -0800)
commitb5a0faa3572ac70bd374bd66190ac3ad4fddab20
tree8fff54e70d9cc37f03c8c0a9b21e294cada7ccce
parentd4ffb02dee2fcb20e0c8086a8d1305bf885820bb
taprio: don't reject same mqprio settings

The taprio qdisc allows to set mqprio setting but only once. In case
if mqprio settings are provided next time the error is returned as
it's not allowed to change traffic class mapping in-flignt and that
is normal. But if configuration is absolutely the same - no need to
return error. It allows to provide same command couple times,
changing only base time for instance, or changing only scheds maps,
but leaving mqprio setting w/o modification. It more corresponds the
message: "Changing the traffic mapping of a running schedule is not
supported", so reject mqprio if it's really changed.

Also corrected TC_BITMASK + 1 for consistency, as proposed.

Fixes: a3d43c0d56f1 ("taprio: Add support adding an admin schedule")
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Tested-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_taprio.c