tcp: ulp: fix possible crash in tcp_diag_get_aux_size()
authorEric Dumazet <edumazet@google.com>
Thu, 5 Sep 2019 20:20:41 +0000 (13:20 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Sep 2019 15:32:28 +0000 (17:32 +0200)
commitb58662a5f7f4677debd5e28d10145cf5decd516b
tree32d0dcfaa1ed927c724a286773a3e47317f9f780
parent3dd97a08271f031bd54c61e65b6b0ebfb0c404b7
tcp: ulp: fix possible crash in tcp_diag_get_aux_size()

tcp_diag_get_aux_size() can be called with sockets in any state.

icsk_ulp_ops is only present for full sockets.

For SYN_RECV or TIME_WAIT ones we would access garbage.

Fixes: 61723b393292 ("tcp: ulp: add functions to dump ulp-specific information")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Luke Hsiao <lukehsiao@google.com>
Reported-by: Neal Cardwell <ncardwell@google.com>
Cc: Davide Caratti <dcaratti@redhat.com>
Acked-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_diag.c