mac80211_hwsim: Fix possible null-pointer dereferences in hwsim_dump_radio_nl()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 29 Jul 2019 08:23:32 +0000 (16:23 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 29 Jul 2019 14:20:34 +0000 (16:20 +0200)
commitb55f3b841099e641bdb2701d361a4c304e2dbd6f
tree0d6ddf7fb0db9a3a9b1a8ad435d08aae0a6557aa
parent05aaa5c97dce4c10a9e7eae2f1569a684e0c5ced
mac80211_hwsim: Fix possible null-pointer dereferences in hwsim_dump_radio_nl()

In hwsim_dump_radio_nl(), when genlmsg_put() on line 3617 fails, hdr is
assigned to NULL. Then hdr is used on lines 3622 and 3623:
    genl_dump_check_consistent(cb, hdr);
    genlmsg_end(skb, hdr);

Thus, possible null-pointer dereferences may occur.

To fix these bugs, hdr is used here when it is not NULL.

This bug is found by a static analysis tool STCheck written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Link: https://lore.kernel.org/r/20190729082332.28895-1-baijiaju1990@gmail.com
[put braces on all branches]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/mac80211_hwsim.c