mtd: base-files: Unify dual-firmware devices (Linksys)
authorJeff Kletsky <git-commits@allycomm.com>
Wed, 10 Apr 2019 15:28:01 +0000 (08:28 -0700)
committerChristian Lamparter <chunkeey@gmail.com>
Sat, 18 May 2019 11:43:51 +0000 (13:43 +0200)
commitb3770eaca39f223faecfcc0d169a1bb2f6f9464a
tree4697e1277e06775e1fdf0e36aadbe1f636b22806
parent4bdc873a5fda60557478a4294983cf71e7eccea6
mtd: base-files: Unify dual-firmware devices (Linksys)

Consistently handle boot-count reset and upgrade across
ipq40xx, ipq806x, kirkwood, mvebu

Dual-firmware devices often utilize a specific MTD partition
to record the number of times the boot loader has initiated boot.

Most of these devices are NAND, typically with a 2k erase size.
When this code was ported to the ipq40xx platform, the device in hand
used NOR for this partition, with a 16-byte "record" size. As the
implementation of `mtd resetbc` is by-platform, the hard-coded nature
of this change prevented proper operation of a NAND-based device.

* Unified the "NOR" variant with the rest of the Linksys variants

* Added logging to indicate success and failure

* Provided a meaningful return value for scripting

* "Protected" the use of `mtd resetbc` in start-up scripts so that
   failure does not end the boot sequence

* Moved Linksys-specific actions into common `/etc/init.d/bootcount`

For upgrade, these devices need to determine which partition to flash,
as well as set certain U-Boot envirnment variables to change the next
boot to the newly flashed version.

* Moved upgrade-related environment changes out of bootcount

* Combined multiple flashes of environment into single one

* Current-partition detection now handles absence of `boot_part`

Runtime-tested: Linksys EA8300

Signed-off-by: Jeff Kletsky <git-commits@allycomm.com>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
[checkpatch.pl fixes, traded split strings for 80+ chars per line]
15 files changed:
package/system/mtd/src/Makefile
package/system/mtd/src/linksys_bootcount.c
package/system/mtd/src/linksys_bootcount_fix.c [deleted file]
target/linux/ipq40xx/base-files/etc/init.d/bootcount
target/linux/ipq40xx/base-files/etc/init.d/zlinksys_recovery [deleted file]
target/linux/ipq40xx/base-files/lib/upgrade/linksys.sh
target/linux/ipq806x/base-files/etc/init.d/bootcount [new file with mode: 0755]
target/linux/ipq806x/base-files/etc/init.d/linksys_recovery [deleted file]
target/linux/ipq806x/base-files/lib/upgrade/linksys.sh
target/linux/kirkwood/base-files/etc/init.d/bootcount [new file with mode: 0755]
target/linux/kirkwood/base-files/etc/init.d/linksys_recovery [deleted file]
target/linux/kirkwood/base-files/lib/upgrade/linksys.sh
target/linux/mvebu/base-files/etc/init.d/bootcount [new file with mode: 0755]
target/linux/mvebu/base-files/etc/init.d/linksys_recovery [deleted file]
target/linux/mvebu/base-files/lib/upgrade/linksys.sh