[SCSI] qla2xxx: fix error handling of qla2x00_mem_alloc()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 21 Jan 2014 07:00:10 +0000 (10:00 +0300)
committerJames Bottomley <JBottomley@Parallels.com>
Sat, 15 Mar 2014 17:18:53 +0000 (10:18 -0700)
commitb2a72ec32d0f499aaadf41264232517a12326df0
tree833b52ec458e849ce50843631a84fabd80897a31
parent2193b1b16cc7c690f74f917c50004dd00c99088e
[SCSI] qla2xxx: fix error handling of qla2x00_mem_alloc()

qla2x00_mem_alloc() returns 1 on success and -ENOMEM on failure.  On the
one hand the caller assumes non-zero is success but on the other hand
the caller also assumes that it returns an error code.

I've fixed it to return zero on success and a negative error code on
failure.  This matches the documentation as well.

[jejb: checkpatch fix]
Fixes: e315cd28b9ef ('[SCSI] qla2xxx: Code changes for qla data structure refactoring')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/qla2xxx/qla_os.c