Revert "samba36: add hotplug support"
authorRafał Miłecki <rafal@milecki.pl>
Tue, 25 Dec 2018 17:46:44 +0000 (18:46 +0100)
committerRafał Miłecki <rafal@milecki.pl>
Fri, 28 Dec 2018 22:09:38 +0000 (23:09 +0100)
commitae622c93b3b4df7a55ef2cdb9986eec2bf42159b
tree91a41047e9e26ca08fba366c06d82918e7934c2c
parent3c899aaf11580353bc9ab1c3d9c3f638db80ba7c
Revert "samba36: add hotplug support"

This reverts commit fd569e5e9d0a46ea957cb253e97a4b3ea8c2c540.

After an extra review & discussion few concerns were raised regarding
that feature:
1) It reacts to hotplug.d "block" events instead of more accurate (but
   currently unavailable) "mount" events.
2) It requires *something* to mount block device before samba hotplug.d
   gets fired. Otherwise samba_add_section() will just return.
3) It doesn't reload Samba which some users may expect
4) It operates on /etc/ which is not a right place for autogenerated
   ephemeral config.
5) It doesn't include any cleanup for non-existing shares.

Cc: Rosy Song <rosysong@rosinson.com>
Cc: Jo-Philipp Wich <jo@mein.io>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
package/network/services/samba36/Makefile
package/network/services/samba36/files/lib/samba.sh [deleted file]
package/network/services/samba36/files/samba.hotplug [deleted file]