soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get()
authorDouglas Anderson <dianders@chromium.org>
Thu, 6 Sep 2018 22:49:05 +0000 (15:49 -0700)
committerAndy Gross <andy.gross@linaro.org>
Mon, 24 Sep 2018 04:28:01 +0000 (21:28 -0700)
commitabc1c94471450de4fa085f5b1269837f97b1adc5
tree13c02f560f57bb0c769433bb1827b3765d49011c
parent65a272642ce13aab911f68279c8994cde3282b0a
soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get()

The function clk_round_rate() is defined to return a "long", not an
"unsigned long".  That's because it might return a negative error
code.  Change the call in geni_se_clk_tbl_get() to check for errors.

While we're at it, get rid of a useless init of "freq".

NOTE: overall the idea that we should iterate over clk_round_rate() to
try to reconstruct a table already present in the clock driver is
questionable.  Specifically:
- This method relies on "clk_round_rate()" rounding up.
- This method only works if the table is sorted and has no duplicates.
...this patch doesn't try to fix those problems, it just makes the
error handling more correct.

Fixes: eddac5af0654 ("soc: qcom: Add GENI based QUP Wrapper driver")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
drivers/soc/qcom/qcom-geni-se.c