cgroup: use an ordered workqueue for cgroup destruction
authorHugh Dickins <hughd@google.com>
Thu, 6 Feb 2014 23:56:01 +0000 (15:56 -0800)
committerTejun Heo <tj@kernel.org>
Fri, 7 Feb 2014 15:21:12 +0000 (10:21 -0500)
commitab3f5faa6255a0eb4f832675507d9e295ca7e9ba
tree1f9a906214d8f20bf9f58ccb202d2eb8dade8db4
parent0a6be6555302eebb14510fd6b35bb17e8dfa1386
cgroup: use an ordered workqueue for cgroup destruction

Sometimes the cleanup after memcg hierarchy testing gets stuck in
mem_cgroup_reparent_charges(), unable to bring non-kmem usage down to 0.

There may turn out to be several causes, but a major cause is this: the
workitem to offline parent can get run before workitem to offline child;
parent's mem_cgroup_reparent_charges() circles around waiting for the
child's pages to be reparented to its lrus, but it's holding cgroup_mutex
which prevents the child from reaching its mem_cgroup_reparent_charges().

Just use an ordered workqueue for cgroup_destroy_wq.

tj: Committing as the temporary fix until the reverse dependency can
    be removed from memcg.  Comment updated accordingly.

Fixes: e5fca243abae ("cgroup: use a dedicated workqueue for cgroup destruction")
Suggested-by: Filipe Brandenburger <filbranden@google.com>
Signed-off-by: Hugh Dickins <hughd@google.com>
Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cgroup.c