media: fix airspy usb probe error path
authorJames Patrick-Evans <james@jmp-e.com>
Fri, 15 Jul 2016 15:40:45 +0000 (16:40 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 15 Jul 2016 21:15:40 +0000 (06:15 +0900)
commitaa93d1fee85c890a34f2510a310e55ee76a27848
tree9b73ec6447103649523c514c537d3c10d62974a2
parent0ba169ac3600ae4032ee14b4192e6bf5d67723f5
media: fix airspy usb probe error path

Fix a memory leak on probe error of the airspy usb device driver.

The problem is triggered when more than 64 usb devices register with
v4l2 of type VFL_TYPE_SDR or VFL_TYPE_SUBDEV.

The memory leak is caused by the probe function of the airspy driver
mishandeling errors and not freeing the corresponding control structures
when an error occours registering the device to v4l2 core.

A badusb device can emulate 64 of these devices, and then through
continual emulated connect/disconnect of the 65th device, cause the
kernel to run out of RAM and crash the kernel, thus causing a local DOS
vulnerability.

Fixes CVE-2016-5400

Signed-off-by: James Patrick-Evans <james@jmp-e.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Cc: stable@vger.kernel.org # 3.17+
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/media/usb/airspy/airspy.c