drm/i915/uc: Use -EIO code for GuC initialization failures
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Sun, 11 Aug 2019 19:51:32 +0000 (19:51 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 12 Aug 2019 08:47:43 +0000 (09:47 +0100)
commita5f978c3609f02ae0ccff1bf010b32e41707ef66
treed8809106a6a5ca6dfa5c61bbd99ea94bbe5484a4
parent07587c3435110e172051c3a1fa0764027a1815f8
drm/i915/uc: Use -EIO code for GuC initialization failures

Since commit 6ca9a2beb54a ("drm/i915: Unwind i915_gem_init() failure")
we believed that we correctly handle all errors encountered during
GuC initialization, including special one that indicates request to
run driver with disabled GPU submission (-EIO).

Unfortunately since commit 121981fafe69 ("drm/i915/guc: Combine
enable_guc_loading|submission modparams") we stopped using that
error code to avoid unwanted fallback to execlist submission mode.

In result any GuC initialization failure was treated as non-recoverable
error leading to driver load abort, so we could not even read related
GuC error log to investigate cause of the problem.

For now always return -EIO on any uC hardware related failure.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20190811195132.9660-5-michal.wajdeczko@intel.com
drivers/gpu/drm/i915/gt/uc/intel_uc.c
drivers/gpu/drm/i915/i915_gem.c