xfrm: do not leak ESRCH to user space
authorfernando@oss.ntt.co <fernando@oss.ntt.co>
Thu, 23 Oct 2008 04:27:19 +0000 (04:27 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 31 Oct 2008 07:06:03 +0000 (00:06 -0700)
commita432226614c5616e3cfd211e0acffa0acfb4770c
tree2189d97e001e8ad9173ec40c27f6a28ab109db2f
parent3a8af722495469e9c550386b910c5b93c91cf107
xfrm: do not leak ESRCH to user space

I noticed that, under certain conditions, ESRCH can be leaked from the
xfrm layer to user space through sys_connect. In particular, this seems
to happen reliably when the kernel fails to resolve a template either
because the AF_KEY receive buffer being used by racoon is full or
because the SA entry we are trying to use is in XFRM_STATE_EXPIRED
state.

However, since this could be a transient issue it could be argued that
EAGAIN would be more appropriate. Besides this error code is not even
documented in the man page for sys_connect (as of man-pages 3.07).

Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/xfrm/xfrm_policy.c