uprobes: Change read_opcode() to use FOLL_FORCE
authorOleg Nesterov <oleg@redhat.com>
Tue, 29 May 2012 19:27:59 +0000 (21:27 +0200)
committerIngo Molnar <mingo@kernel.org>
Wed, 6 Jun 2012 15:14:49 +0000 (17:14 +0200)
commita3d7bb47937b3a40b9f0c75655e97b3bb6407cbe
treeac573bd042efa291c71c956930c81d80e79e4a69
parentc00b275043adc14d668f36266b890f0c53d46640
uprobes: Change read_opcode() to use FOLL_FORCE

set_orig_insn()->read_opcode() should not fail if the probed
task did mprotect() after uprobe_register(), change it to use
FOLL_FORCE. Without FOLL_WRITE this doesn't have any "side"
effect but allows to read the !VM_READ memory.

There is another reason for this change, we are going to use
is_swbp_at_addr() from handle_swbp() which can race with another
thread doing mprotect().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Anton Arapov <anton@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20120529192759.GB8057@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/events/uprobes.c