enic: fix return values in enic_set_coalesce
authorGovindarajulu Varadarajan <_govind@gmx.com>
Wed, 2 Jul 2014 10:12:15 +0000 (15:42 +0530)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Jul 2014 04:33:46 +0000 (21:33 -0700)
commita16a3361927f75e6032df110920c83ca6c5045d3
treefa137120fad58594d535c208aebb1d15fd67a240
parente721f87d806f2a959d6a530be18dabee6097aa79
enic: fix return values in enic_set_coalesce

enic_set_coalesce() has two problems.

* It should return -EINVAL and not -EOPNOTSUPP for invalid coalesce values.

* In case of MSIX, enic_set_coalesce return error after applying requested
  coalescing setting partially. We should either apply all the setting requeste
  and return success or apply non and return error.

* This patch also simplifies the algo.

This was introduced by
'7c2ce6e60f703 enic: Add support for adaptive interrupt coalescing'

These changes were suggested by Ben Hutchings here
http://www.spinics.net/lists/netdev/msg283972.html

Also change enic driver version.

Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cisco/enic/enic.h
drivers/net/ethernet/cisco/enic/enic_ethtool.c