Revert "net: init sk_cookie for inet socket"
authorYafang Shao <laoar.shao@gmail.com>
Tue, 24 Apr 2018 15:07:45 +0000 (23:07 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Apr 2018 15:15:32 +0000 (11:15 -0400)
commita06ac0d67d9fda7c255476c6391032319030045d
tree8ed0839695d99367f1e75dc1968c422b91a340c6
parent8399743a5a6796c8d5858ae3c5afc814201112d4
Revert "net: init sk_cookie for inet socket"

This reverts commit <c6849a3ac17e> ("net: init sk_cookie for inet socket")

Per discussion with Eric, when update sock_net(sk)->cookie_gen, the
whole cache cache line will be invalidated, as this cache line is shared
with all cpus, that may cause great performace hit.

Bellow is the data form Eric.
"Performance is reduced from ~5 Mpps to ~3.8 Mpps with 16 RX queues on
my host" when running synflood test.

Have to revert it to prevent from cache line false sharing.

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/sock_diag.h
net/ipv4/tcp_input.c