vfs: deny fallocate() on directory
authorAmir Goldstein <amir73il@gmail.com>
Tue, 31 Jan 2017 08:34:55 +0000 (10:34 +0200)
committerMiklos Szeredi <mszeredi@redhat.com>
Tue, 7 Feb 2017 14:05:04 +0000 (15:05 +0100)
commit9e79b1326302589a035fe20e8cce7c1a7d8333ed
tree80ba2823440ee9f7915b40c43d211e9e0be71d8c
parentaf7bd4dc13093bf1477f370722bbab24cf457b91
vfs: deny fallocate() on directory

There was an obscure use case of fallocate of directory inode
in the vfs helper with the comment:
"Let individual file system decide if it supports preallocation
 for directories or not."

But there is no in-tree file system that implements fallocate
for directory operations.

Deny an attempt to fallocate a directory with EISDIR error.

This change is needed prior to converting sb_start_write()
to  file_start_write(), so freeze protection is correctly
handled for cases of fallocate file and blockdev.

Cc: linux-api@vger.kernel.org
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/open.c