sctp: not bind the socket in sctp_connect
authorXin Long <lucien.xin@gmail.com>
Wed, 26 Jun 2019 08:31:39 +0000 (16:31 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 29 Jun 2019 17:48:45 +0000 (10:48 -0700)
commit9b6c08878e23adb7cc84bdca94d8a944b03f099e
tree06e61a24c34e5a66614991cfd69fb651ec9d6205
parent8ec3ede559956f8ad58db7b57d25ac724bab69e9
sctp: not bind the socket in sctp_connect

Now when sctp_connect() is called with a wrong sa_family, it binds
to a port but doesn't set bp->port, then sctp_get_af_specific will
return NULL and sctp_connect() returns -EINVAL.

Then if sctp_bind() is called to bind to another port, the last
port it has bound will leak due to bp->port is NULL by then.

sctp_connect() doesn't need to bind ports, as later __sctp_connect
will do it if bp->port is NULL. So remove it from sctp_connect().
While at it, remove the unnecessary sockaddr.sa_family len check
as it's already done in sctp_inet_connect.

Fixes: 644fbdeacf1d ("sctp: fix the issue that flags are ignored when using kernel_connect")
Reported-by: syzbot+079bf326b38072f849d9@syzkaller.appspotmail.com
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c