binutils: fix libbfd missing DSO dependency if NLS enabled
authorTony Ambardar <itugrok@yahoo.com>
Sun, 28 Mar 2021 07:40:31 +0000 (00:40 -0700)
committerHauke Mehrtens <hauke@hauke-m.de>
Sat, 3 Apr 2021 16:56:02 +0000 (18:56 +0200)
commit9a59f62f613b1ca774032ccd80c51c74491b142c
tree9332ac1bbd85d2a6549cce66c30f378b18873c2b
parentc8c638a19b63bf6c3bf8094aebd8fde6feda36ba
binutils: fix libbfd missing DSO dependency if NLS enabled

The libbfd package definition uses $(ICONV_DEPENDS) and $(INTL_DEPENDS)
but links against neither, leading to libbfd detection failures in other
packages (e.g. bpftools) and on-target relocation problems with libintl.so:

  root@OpenWrt:/# ldd /usr/lib/libbfd.so
        ldd (0x77db6000)
        libc.so => ldd (0x77db6000)
        libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x77c6d000)
  Error relocating /usr/lib/libbfd.so: libintl_dgettext: symbol not found

Add NLS-conditional linking of "libintl" to fix this. Also remove libbfd
package dependency $(ICONV_DEPENDS) which is not used during building or
linking.

Tested with QEMU on malta/be32, after building all packages from binutils,
bpftools and iproute2, using different libc options musl and glibc.

Fixes: 08e817569630 ("binutils: use nls.mk to fix libbfd link errors in
other packages")
Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
package/devel/binutils/Makefile