drm/i915: Avoid use-after-free of intel_encoder in intel_dp_connector_destrpy
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 20 Jun 2016 08:29:17 +0000 (09:29 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 20 Jun 2016 13:21:43 +0000 (15:21 +0200)
commit996818869c9cc25581e81ff809d790651129cb4a
tree94a66a5845516f343fad0515d828a401953fb899
parente63d87c0b02f2f0ee876ea79dcbe13a7235a2d55
drm/i915: Avoid use-after-free of intel_encoder in intel_dp_connector_destrpy

The drm_dp_aux is associated with the intel_dp encoder and not the
connector. Since the encoder is destroyed before the connector,
attempting to free the drm_dp_aux from inside the connector cleanup
causes a use-after-free.

This was applied to the patch that CI was happy with, but in the
confusion of so many series trying to make CI happy, the unready
patch was plucked.

Fixes: c191eca110a3 ("drm/i915: Move intel_connector->unregister to connector->early_unregister")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1466411357-730-1-git-send-email-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_dp.c