nfsd: make sure to balance get/put_write_access
authorChristoph Hellwig <hch@infradead.org>
Mon, 18 Nov 2013 13:07:47 +0000 (05:07 -0800)
committerJ. Bruce Fields <bfields@redhat.com>
Mon, 18 Nov 2013 17:06:48 +0000 (12:06 -0500)
commit987da4791052fa298b7cfcde4dea9f6f2bbc786b
tree8a469919f3990db2f496db44cb6a3d36d32569c4
parent818e5a22e907fbae75e9c1fd78233baec9fa64b6
nfsd: make sure to balance get/put_write_access

Use a straight goto error label style in nfsd_setattr to make sure
we always do the put_write_access call after we got it earlier.

Note that the we have been failing to do that in the case
nfsd_break_lease() returns an error, a bug introduced into 2.6.38 with
6a76bebefe15d9a08864f824d7f8d5beaf37c997 "nfsd4: break lease on nfsd
setattr".

Signed-off-by: Christoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/vfs.c