net: phy: marvell: Use strlcpy() for ethtool::get_strings
authorFlorian Fainelli <f.fainelli@gmail.com>
Fri, 2 Mar 2018 23:08:37 +0000 (15:08 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 6 Mar 2018 16:12:39 +0000 (11:12 -0500)
commit98409b2bbca36b578be8e66758e6acb96e4c91da
tree343ec3edd663ca132dcb1b97c990fc4d94fdf2ae
parentcd526676de1ece03a8ea7cea726cf879a2dba2b8
net: phy: marvell: Use strlcpy() for ethtool::get_strings

Our statistics strings are allocated at initialization without being
bound to a specific size, yet, we would copy ETH_GSTRING_LEN bytes using
memcpy() which would create out of bounds accesses, this was flagged by
KASAN. Replace this with strlcpy() to make sure we are bound the source
buffer size and we also always NUL-terminate strings.

Fixes: d2fa47d9dd5c ("phy: marvell: Add ethtool statistics counters")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/marvell.c