[PATCH] initialize parts of udf inode earlier in create
authorDan Bastone <dan@pwienterprises.com>
Mon, 14 Aug 2006 06:24:18 +0000 (23:24 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 14 Aug 2006 19:54:28 +0000 (12:54 -0700)
commit95f8797f42b058333d1e6f0d1dcd8edf5dc6c244
treef0f0cc374b0d0d884210f3cdbd0774efe3b79fe9
parent1725cd0ae07bb31f68803edcc5bdc99952c7d2f4
[PATCH] initialize parts of udf inode earlier in create

Eric says:

> I saw an oops down this path when trying to create a new file on a UDF
> filesystem which was internally marked as readonly, but mounted rw:
>
> udf_create
>         udf_new_inode
>                 new_inode
>                         alloc_inode
>                          udf_alloc_inode
>                 udf_new_block
>                         returns EIO due to readonlyness
>                 iput (on error)

I ran into the same issue today, but when listing a directory with
invalid/corrupt entries:

udf_lookup
        udf_iget
                get_new_inode_fast
                        alloc_inode
                                udf_alloc_inode
                __udf_read_inode
                        fails for any reason
                iput (on error)
                        ...

The following patch to udf_alloc_inode() should take care of both (and
other similar) cases, but I've only tested it with udf_lookup().

Signed-off-by: Dan Bastone <dan@pwienterprises.com>
Cc: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/udf/super.c